Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate components and fix bugs for EKS Container Insights #3846

Merged
merged 11 commits into from
Jun 24, 2021
Merged

Integrate components and fix bugs for EKS Container Insights #3846

merged 11 commits into from
Jun 24, 2021

Conversation

pxaws
Copy link
Contributor

@pxaws pxaws commented Jun 21, 2021

Description:
This PR integrates various components of Container Insights and fixes some bugs.

  • set region in aws session for ec2 tags
  • add decoration logic with host info
  • add configurations for metric decoration with pod/service store
  • initialize k8s client on demand to save memory
  • fix the jitter issue that happens randomly
  • add attributes to cluster-level metrics

Link to tracking Issue:
#2307

@pxaws pxaws requested a review from anuraaga as a code owner June 21, 2021 16:32
@pxaws pxaws requested a review from a team June 21, 2021 16:32
mxiamxia
mxiamxia approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alolita
Copy link
Member

alolita commented Jun 23, 2021

@open-telemetry/collector-approvers @jpkrohling can one of you please review before I mark this PR as ready-to-merge.

@bogdandrutu bogdandrutu merged commit 31211aa into open-telemetry:main Jun 24, 2021
Saber-W referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 17, 2021
@bogdandrutu
Bump google.golang.org/grpc from 1.39.0 to 1.40.0 in /model (#3846)
a3a152f 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@pxaws pxaws mentioned this pull request Jul 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@mxiamxia mxiamxia mxiamxia approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pxaws @alolita @anuraaga @Aneurysm9 @mxiamxia @jpkrohling @bogdandrutu